search

sindresorhus / notifier-for-github

Browser extension - Get notified about new GitHub notifications
MIT License
1.82k stars 133 forks source link

Sound doesn't work, `bell.ogg` missing #272

Closed andylizi closed 1 year ago

andylizi commented 1 year ago

For some reason, /sounds/bell.ogg is missing from the packaged extension.

GET chrome-extension://lmjdlojahmbbcodnpecnjnmlddbkjhnn/sounds/bell.ogg net::ERR_FILE_NOT_FOUND
DOMException: Failed to load because no supported source was found.

Notifications are also affected by this error as they're triggered after playNotificationSound().

Running npm run build will output:

√ Built in 14.60s

distribution\manifest.json               846 B    372ms
distribution\icon-notif.png            1.67 KB    407ms
distribution\icon.png                  1.24 KB    407ms
distribution\icon-toolbar.png            553 B    406ms
distribution\background.js           103.67 KB    437ms
distribution\options.html              2.64 KB    406ms
distribution\options.5e2d4b3a.css         4 KB    433ms
distribution\options.f5a2a783.js      92.91 KB    437ms

This may be similar to #259.