sindresorhus / notifier-for-github

Browser extension - Get notified about new GitHub notifications

MIT License

1.82k stars 132 forks source link

URGENT: Manifest v3 #297

Closed Malix-Labs closed 2 weeks ago

Malix-Labs commented 1 month ago

Urgent

The extension will soon be unusable on Chromium due to the deprecation of Manifest v2

It needs to make the transition to Manifest v3

notlmn commented 1 month ago

I have a draft at #298, but Firefox doesn't support offscreen permission yet which is needed to play audio as part of manifest v3.

Malix-Labs commented 1 month ago

@notlmn thanks for the notice!

Can you link that issue to the pull request please?

niu541412 commented 1 month ago

Firefox still supports manifest v2 and seems to have no plan to drop it. So keeping the version unchanged in the Firefox add-on store is ok.

I have a draft at #298, but Firefox doesn't support offscreen permission yet which is needed to play audio as part of manifest v3.

Malix-Labs commented 1 month ago

I have a draft at https://github.com/sindresorhus/notifier-for-github/pull/298

Very nice !

but Firefox doesn't support offscreen permission yet which is needed to play audio as part of manifest v3.

The biggest threat is that the extension will be automatically force uninstalled when chrome will drop manifest v2 support, so a manifest v3 has to be published before that to not drop a huge proportion of its userbase

subdavis commented 3 weeks ago

FWIW, I've seen many extension developers have separate build configs for chrome and ff. I recently upgraded an extension to mv3 while leaving firefox as v2. Here's my manifest generation file: https://github.com/subdavis/Tusk/blob/main/scripts/manifest.ts

Malix-Labs commented 3 weeks ago

I've seen many extension developers have separate build configs for chrome and ff

Indeed

See the top 3 tools comparison