Migrate to Extension Manifest v3

sindresorhus / notifier-for-github

Browser extension - Get notified about new GitHub notifications

MIT License

1.84k stars 132 forks source link

Migrate to Extension Manifest v3 #298

Closed notlmn closed 2 months ago

notlmn commented 3 months ago

Fixes: #297

Move background to a service worker
Move audio playback to offscreen file
Convert script types to modules in options and offscreen
Update minimum browser versions for Chrome and Firefox
Update dev dependencies as needed
Update tests as needed (remove some individual tests)
Disable badge-test as sinon-chrome does not have stub for browser.action API
Disable auto-publishing to AMO due to lack of offscreen API in Firefox

notlmn commented 2 months ago

@sindresorhus can you do a manual release to CWS from this branch instead of the default one? Or do you have any other suggestions for working around v2 and v3 releases.

This one fails to run for Firefox because there's no offscreen API in Firefox yet.

sindresorhus commented 2 months ago

I think it would be better to just disable Firefox auto-publishing for now: https://github.com/sindresorhus/notifier-for-github/blob/main/.github/workflows/release.yml