search

sindresorhus / npm-keyword

Get a list of npm packages with keywords
MIT License
52 stars 8 forks source link

Update search endpoint #11

Closed mischah closed 6 years ago

mischah commented 6 years ago

This will close #9.

I’ve used the npm API instead of the npms API since they both share the same limitations. See change in README. Reason: the »native« API might be better maintained. Plus this makes sure this package keeps working with a private registry.

Let me know if you would like me to change this nevertheless.

Question

Do you we should expose the size param to this modules API?

sindresorhus commented 6 years ago

Do you we should expose the size param to this modules API?

Yes, as an option object:

keyword('foo', {size: 10});

It should default to 250 though.

mischah commented 6 years ago

Ready for another review 😘

sindresorhus commented 6 years ago

Looks awesome. Thank you :)

mischah commented 6 years ago

Thank you 💯