Fix $ sign url escaping in WSL 2

sindresorhus / open

Open stuff like URLs, files, executables. Cross-platform.

MIT License

3.18k stars 219 forks source link

Fix $ sign url escaping in WSL 2 #203

Closed CryogenicPlanet closed 3 years ago

CryogenicPlanet commented 3 years ago

Closes #202

tim-stasse commented 3 years ago

Did you read the comment on line 100?

CryogenicPlanet commented 3 years ago

My bad I completely missed that @tim-stasse, how would you recommend fixing #202. I wasn't able to think of a good way to escape the $ sign, for it to work in wsl the cli should get it escaped as \$ but javascript was automatically changing that to $ for me

An6r commented 3 years ago

Does anyone have news about this one?

sindresorhus commented 3 years ago

@CryogenicPlanet Still interested in trying to fix this?

CryogenicPlanet commented 3 years ago

Hey @sindresorhus, sorry won't be able to work on this anymore. Had some other issues with WSL and now moved to linux proper so don't have WSL on hand to test a solution, even if I came up with one.