search

sindresorhus / ora

Elegant terminal spinner
MIT License
9.15k stars 271 forks source link

Don't allow `default` as a spinner #175

Closed erezrokah closed 3 years ago

erezrokah commented 3 years ago

Hello 👋

Thank you for this great tool ❤️

I spotted this bug while working on https://github.com/netlify/cli/pull/2576.

Currently 'default' passes the validation while not being a valid spinner name.

erezrokah commented 3 years ago

Also, not sure why the other validation test is disabled on windows: https://github.com/sindresorhus/ora/blob/c7d6dba4a723cfa640e6adb716cb6b5dad2c22d2/test.js#L315

so I figured I'll try to run the new one on all platforms