sindresorhus / ora

Elegant terminal spinner
MIT License
9.08k stars 269 forks source link

v8 stop but do not release #233

Closed peterpeterparker closed 8 months ago

peterpeterparker commented 8 months ago

Hi, I just tried the newest version of ora which I use in my CLI.

While the spinner still works, it seems to not release some process which has for effect to make my CLI commands hang forever.

Example of code:

export const clear = async () => {
  try {
    await doSomething();
  } finally {
    spinner.stop();
  }
};

With v7.0.1:

ok

With v8.0.0:

notok

In the above gif, when it hangs, I try to hit few "Return" on my keyboard and ends the process with Ctrl+C at the end.

ipec commented 8 months ago

I can confirm this issue with ora version 8.0.0 in my environment. Experiencing similar behavior where the CLI commands hang after executing.

peterpeterparker commented 8 months ago

I can confirm the fix works out. Thanks a lot, merry Xmas! 🎄