Recent change for concurrency is breaking change

sindresorhus / p-limit

Run multiple promise-returning & async functions with limited concurrency

MIT License

2.06k stars 106 forks source link

Recent change for concurrency is breaking change #17

Closed drewlindsey closed 5 years ago

drewlindsey commented 5 years ago

Should we up the major version since it no longer can take in a string value for concurrency which may technically be a backwards incompatible change. I know my lib broke from "p-limit": "^2.2.0", which was automatically pulled in on the latest change.

sindresorhus commented 5 years ago

It's not a breaking change. concurrency was always documented as being a number.