search

sindresorhus / p-limit

Run multiple promise-returning & async functions with limited concurrency
MIT License
2.06k stars 106 forks source link

Refactor #85

Open tuhm1 opened 4 months ago

tuhm1 commented 4 months ago

Nothing important, I just thought the code was getting a bit messy and might be hard to maintain in the future. Please feel free to reject if you find these changes unnecessary.

sindresorhus commented 4 months ago

I definitely welcome simplifications. I just worry that this would introduce regressions that are not covered by our tests.

tuhm1 commented 4 months ago

I understand your concern. I don't think there would be any problem, but it may not be worth the risk. Take your time to consider.

sindresorhus commented 4 months ago

@sugoroku-y Would you be able to help review this?

sugoroku-y commented 4 months ago

I understood all the comments, but I still think that unnecessary changes make the decision to accept this pull request more difficult.

I don't see anything wrong in the code, so I will defer to Owner @sindresorhus for the final decision.