Allow cache to be async

sindresorhus / p-memoize

Memoize promise-returning & async functions

MIT License

396 stars 30 forks source link

Allow cache to be async #26

Closed Richienb closed 3 years ago

Richienb commented 3 years ago

Fixes #3, Fixes #14, Closes #19

sindresorhus commented 3 years ago

CI is failing.

sindresorhus commented 3 years ago

For future reference, it would have been better if this pull request was split into a separate pull request for each issue it fixed. Massive pull requests are a pain to review.

sindresorhus commented 3 years ago

Does this introduce any breaking changes other than removal of maxAge? Would you be able to list the changes in this PR which can be used for the release notes?

Richienb commented 3 years ago

Allow .get() and .has() cache methods to return a promise
Remove maxAge option. This means instead of .set() being provided an object with the properties value and maxAge, it will only be provided value as the first argument.
Promises returned from a memoized function will be cached internally and take priority over cache. The promise cache does not persist outside of the current instance and properties assigned to a returned promise will not be kept.
cache will be provided the values of resolved promises instead of the promises themselves.

sindresorhus commented 3 years ago

@Richienb Thanks for working on this. This is ready to be released right? There are no more planned breaking changes?

Richienb commented 3 years ago

@sindresorhus Nothing else from me - it's good to go.

JaneJeon commented 3 years ago

Hallelujah! Thanks for working on this @Richienb