`error` and `completed` events not emitted on v6

sindresorhus / p-queue

Promise queue with concurrency control

MIT License

3.39k stars 182 forks source link

`error` and `completed` events not emitted on v6 #179

Open 0xOlias opened 1 year ago

0xOlias commented 1 year ago

The docs mention error and completed events, but these are not being emitted on v6. I suspect that this is the root cause of a number of open issues (#171, #169).

I would take a stab at a PR to add them, but I'm not sure how the release process works for v6.

sindresorhus commented 1 year ago

v6 is no longer supported. Are these issues reproducible on v7?

0xOlias commented 1 year ago

I'm not sure. I didn't realize v6 was unsupported, that's unfortunate. Feel free to close.

darky commented 1 year ago

Would be better to support v6 too, seems very hard to shift community from cjs -> esm