Node 18 upgrade improvements

sindresorhus / p-timeout

Timeout a promise after a specified amount of time

MIT License

274 stars 32 forks source link

Node 18 upgrade improvements #41

Open fregante opened 10 months ago

fregante commented 10 months ago

I just saw a couple node Node 18-related notes in the code. I'll add a couple more:

Add support for cause in TimeoutError, even if unused locally
- https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1342
Use public fields instead of the constructor (this actually fixes the above issue automatically too)
- https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1993
Ensure that the type for TimeoutError matches these changes, since d.ts file is maintained manually

silverwind commented 9 months ago

For custom errors, the V8-specific Error.captureStackTrace might be nice for a cleaner stack trace. Call it with ?. so it does not fail on non-V8.