search

sindresorhus / pageres

Capture website screenshots
MIT License
9.68k stars 744 forks source link

Use nightmarejs (which use electron) instead of PhantomJS #267

Closed MoOx closed 8 years ago

MoOx commented 8 years ago

PhantomJS engine is kind of outdated and a lot of modern websites are rendered like shit (hello flexbox support). Using NightmareJS (which use electron under the hood) might be a solid option.

SamVerschueren commented 8 years ago

I guess we are going to wait for headless chrome. Unless @sindresorhus has another opinion :).

sindresorhus commented 8 years ago

Last time I checked out NightmareJS it required a bunch of stuff in your Travis file to be able to run headlessly on Linux. Has that changed? Because requiring that is a pretty leaky abstraction and forces everything that uses Pageres to document how to do that. Right now Pageres just works. Pageres now uses PhantomJS 2 which is at least on a somewhat recent version of WebKit and it works pretty ok. I think I'd rather wait on headless Chrome.

MoOx commented 8 years ago

You mean this https://github.com/electron/electron/blob/master/docs/tutorial/testing-on-headless-ci.md#travis-ci?

sindresorhus commented 8 years ago

Yes