Add the verbose option - Githubissues

sindresorhus / pretty-ms

Convert milliseconds to a human readable string: `1337000000` → `15d 11h 23m 20s`

MIT License

1.08k stars 65 forks source link

Add the verbose option #8

Closed icyflame closed 9 years ago

icyflame commented 9 years ago

Fixes #7

I have also added the option to the README.

/ @sindresorhus

icyflame commented 9 years ago

@kevva

I have made all of the changes requested : -

remove shorthand if
use === wherever possible
camelCase variable names
use opts.verbose instead of verbose
add default options to the readme file

Can you please point me to the style guide that you use for this project, for future reference?

cc @arthurvr @sindresorhus

icyflame commented 9 years ago

@kevva Done! Sorry, I missed the space between if and (condition) in the earlier comments. There were also some issues in the function spacing, as pointed out by @arthurvr , which I have fixed too.

icyflame commented 9 years ago

@kevva More spacing changes!

I have followed this convention (mentioned by @arthurvr ) a space after the function keyword, and a space before the opening curly brace.

icyflame commented 9 years ago

@kevva Done! There were empty lines before it, in the existing code. I have removed them, as well as existing empty lines.

@sindresorhus everything has been changed to use plur. I also made the changes to readme.