search

sindresorhus / pure

Pretty, minimal and fast ZSH prompt
MIT License
13.12k stars 971 forks source link

Make sure GPG-agent does not mess up the tty #645

Closed sheeviZi closed 2 years ago

sheeviZi commented 2 years ago

When gpg-agent is used as an ssh-agent and configured with pinentry-ncurses, it messes up the terminal immediately after you cd into a git repository with an ssh remote.

Fixes #366.

I can help you reproduce it if you ask.

IssueHunt Summary ### Referenced issues This pull request has been submitted to: - [#366: pinentry-ncurses in async process mangles inputs for the rest of the session](https://issuehunt.io/repos/5890857/issues/366) ---
antoineco commented 2 years ago

@sheeviZi that looks very simple, but what is the intended effect of this change?

~After applying this patch, I don't have the problem of the mangled input anymore (hurray! 🏆), but I also don't see any pinentry prompt. This is perfectly fine with me, I'm just trying to understand what's going on under the hood.~

Sorry I spoke too fast. Looks like my gpg-agent wasn't set up properly while I was trying to reproduce. See review comment.

sheeviZi commented 2 years ago

@antoineco Thanks for your time.

antoineco commented 2 years ago

@sheeviZi a note about the bounty on this issue.

If you want to claim the reward, you will have to

  1. Log in at https://issuehunt.io/r/sindresorhus/pure/issues/366 using your GitHub account
  2. Click "Submit a Pull Request" on the right hand side of the page
  3. Paste the URL of this PR
antoineco commented 2 years ago

@sheeviZi I saw the request for review but I am only providing feedback as a user, not a maintainer. You will have to wait for a maintainer to get their eyes on this in order to have it merged (if accepted as a solution to the problem).

sheeviZi commented 2 years ago

@antoineco Are you ok with the wiki page?

antoineco commented 2 years ago

Yes I think that looks good, and it's useful information paired with the fix from this PR.

sheeviZi commented 2 years ago

@mafredri is this ok for merge?

sheeviZi commented 2 years ago

@sindresorhus can you please take a look in order to close the linked issue; Otherwise I am not able to claim the bounty on issuehunt.

sheeviZi commented 2 years ago

Thank you @sindresorhus for merging this PR. Just mention me with @sheeviZi if you need anything in the future.