sindresorhus / refined-twitter

Browser extension that simplifies the Twitter interface and adds useful features
MIT License
1.31k stars 89 forks source link

Fix error `val.split is not a function` #134

Closed ryota-murakami closed 6 years ago

ryota-murakami commented 6 years ago

This Extention blow my mind!!

Sammary

Following Error was occurring on my timeline.

screen shot 2018-08-16 at 8 06 41

Investigation

console.log() target value.

screen shot 2018-08-16 at 9 04 41

dump

screen shot 2018-08-16 at 9 03 54

Cause

The cause was passing Text to String.prototype.split().

FIx

I added Text in the early return condition that inner isElement().

But I don't is this way ideally?

Thanks your review😀