Closed sigsiroos closed 5 years ago
This doesn't correctly handle the loading indicator:
If I make the window smaller, the loading indicator ends up above the buttons:
When the window is very wide, the nav buttons are too much to the left. Would be nice to move them closer to the center:
Yikes sorry about that, didn't think of that and the numerous other problems my changes were causing. Fixed this and also covered the other pages being weird by me like e.g. profile and account settings page. However, I get this problem with xo giving errors, something related to eslint or xo itself?
I still think the nav buttons are too much to the left when the window is wide, like showin in https://github.com/sindresorhus/refined-twitter/pull/144#issuecomment-433682110 They could be much closer to the search input.
However, I get this problem with xo giving errors, something related to eslint or xo itself?
This is fixed in master branch. Just rebase from master.
@sigsiroos Looks like you had a bad rebase. Lots of unrelated commits included in the PR now.
Closing for lack of activity. Happy to land a proper fix if you ever get to finish this.
Changed css for header to use flexbox and tweaked stylings to match the twitter header accordingly