search

sindresorhus / refined-twitter

Browser extension that simplifies the Twitter interface and adds useful features
MIT License
1.31k stars 89 forks source link

Use flexbox for the navbar CSS #144

Closed sigsiroos closed 5 years ago

sigsiroos commented 6 years ago

Changed css for header to use flexbox and tweaked stylings to match the twitter header accordingly

sindresorhus commented 6 years ago

This doesn't correctly handle the loading indicator:

screen shot 2018-10-02 at 14 35 53
sindresorhus commented 6 years ago

If I make the window smaller, the loading indicator ends up above the buttons:

screen shot 2018-10-28 at 14 09 39
sindresorhus commented 6 years ago

When the window is very wide, the nav buttons are too much to the left. Would be nice to move them closer to the center:

screen shot 2018-10-28 at 14 10 59
sigsiroos commented 5 years ago

Yikes sorry about that, didn't think of that and the numerous other problems my changes were causing. Fixed this and also covered the other pages being weird by me like e.g. profile and account settings page. However, I get this problem with xo giving errors, something related to eslint or xo itself?

sindresorhus commented 5 years ago

I still think the nav buttons are too much to the left when the window is wide, like showin in https://github.com/sindresorhus/refined-twitter/pull/144#issuecomment-433682110 They could be much closer to the search input.

sindresorhus commented 5 years ago

However, I get this problem with xo giving errors, something related to eslint or xo itself?

This is fixed in master branch. Just rebase from master.

sindresorhus commented 5 years ago

@sigsiroos Looks like you had a bad rebase. Lots of unrelated commits included in the PR now.

sindresorhus commented 5 years ago

Closing for lack of activity. Happy to land a proper fix if you ever get to finish this.