search

sindresorhus / refined-twitter

Browser extension that simplifies the Twitter interface and adds useful features
MIT License
1.31k stars 89 forks source link

Add support for multiple accounts #148

Closed tomma5o closed 5 years ago

tomma5o commented 6 years ago

Hi again @sindresorhus ✋,

Recently I've taken this old task (fixes #1) and I've reached a good point with a working version, is not the definitive one.

In these days I try to fix some spaghetti code ;)

Anyway if you want to try, and give me some feedback, is ready to use 🦄

screenshot 2018-10-09 at 01 40 37
sindresorhus commented 6 years ago

Awesome! Thanks for working on this 🙌

sindresorhus commented 5 years ago

@tomma5o Still interested in finishing this? :)

tomma5o commented 5 years ago

Hi @sindresorhus, Yes, but in the last months I moved to another city and changed jobs :)

I try to close this in this or the next weekend ;)

tomma5o commented 5 years ago

Hi @sindresorhus i've fixed all' the tasks as i promise 😄

FYI twitter approve 🤓🙃 screenshot 2019-01-23 at 15 41 44

tomma5o commented 5 years ago

@sindresorhus any news for this PR ? Or the project is paused for now ?

sindresorhus commented 5 years ago

Or the project is paused for now ?

Sorry for the long delay. I just had too many PRs to review (300+).

sindresorhus commented 5 years ago

This is looking very good! And seems to work very well. 👌

The account removal button isn't styled for dark mode and I think there should also be some more spacing between it and the username:

Screen Shot 2019-05-29 at 21 13 31
sindresorhus commented 5 years ago

Because of https://github.com/sindresorhus/refined-twitter/pull/148#issuecomment-457852769, I understand if you don't want to spend more time on this. But I'd be happy to help you land this if you still want.

tomma5o commented 5 years ago

Sorry for the long delay. I just had too many PRs to review (300+).

Hi, no problem 😄
when I have a slot of free time, I'll fix the last things 👍

c0b41 commented 5 years ago

I think we don't need this feature, right now support this feature. June 4th 2019 Update

sindresorhus commented 5 years ago

Yeah... Sorry for the wasted work @tomma5o. Twitter now supports this natively.