search

sindresorhus / refined-twitter

Browser extension that simplifies the Twitter interface and adds useful features
MIT License
1.31k stars 89 forks source link

Remove "In case you missed ..." notifications? #149

Closed jaddison closed 5 years ago

jaddison commented 6 years ago

I don't think this option exists yet?

screen shot 2018-10-11 at 1 00 46 pm

Related to #103

sindresorhus commented 6 years ago

Good idea. PR welcome.

thedeany commented 6 years ago

@sindresorhus, should this new option be only for the "In case you missed..." notifications? I ask because there is a .with-contextTweet class on the following types of notifications in addition to "In case you missed..." notifications.

If these are going to be added as one option, I could use the .with-contextTweet class to target them. Otherwise, I'll target only the notifications with "In case you missed..." in them.

sindresorhus commented 6 years ago

should this new option be only for the "In case you missed..." notifications?

Yes, the feature should be focused.

jaddison commented 6 years ago

Although I could see an option for each of the following you mentioned being well received by users:

[name] liked a... [name] Retweeted... Recent Tweet from [name] [name] Tweeted after a while

sindresorhus commented 6 years ago

Yes, but should be individual options. I think we have at least some of those implemented already.

thedeany commented 6 years ago

If I add each of those as an option (if they're not already implemented), should they be separate PRs?

thedeany commented 6 years ago

I made a PR for this specific feature. Let me know if the others should be separate PRs as well and I can take a look at them!

sindresorhus commented 6 years ago

If I add each of those as an option (if they're not already implemented), should they be separate PRs?

Yes, separate PRs :)