Don't autoload tweets when a modal is open

sindresorhus / refined-twitter

Browser extension that simplifies the Twitter interface and adds useful features

MIT License

1.31k stars 89 forks source link

Don't autoload tweets when a modal is open #154

Closed joshmanders closed 6 years ago

joshmanders commented 6 years ago

If you're on your timeline and click on reply to a tweet, because it's not on #dm_dialog it still clicks the button, which then closes things like adding gifs or whatever.

All modals in my tests have a .modal class on it, so this changes from #dm_dialog to .modal so that it doesn't autoload when doing anything in a modal.

joshmanders commented 6 years ago

Travis is failing but it has nothing to do with my changes AFAIK.

filipekiss commented 6 years ago

I'll take a look at what's happening with Travis if I have some free time later today. Thanks for the PR!

jorgegonzalez commented 6 years ago

I think it was caused by an XO update? Not sure though.