Closed polomarcus closed 4 years ago
It does not remove ref=producthunt from links
Why?
It does not affect twitter card link like this one as there is no data-expanded-url and we need to have our own link unshorten API
Can't we do the same as you do in https://github.com/polomarcus/faster-links/blob/910eeaf7d78c83d47dbf9116fde143ccf5c77480/app/scripts.babel/contentscript.js#L95 ?
Can't we do the same as you do in https://github.com/polomarcus/faster-links/blob/910eeaf7d78c83d47dbf9116fde143ccf5c77480/app/scripts.babel/contentscript.js#L95 ?
It uses Linkpeelr from @ibagrak , as he hasn't answered me since 2016 I guess it's OK to use it :smile: https://github.com/ibagrak/linkpeelr/issues/15
Would you be OK to use it @sindresorhus ?
About ref=producthunt
, it does not seem that product hunt uses it anymore
Would you be OK to use it @sindresorhus ?
Sure. You can use ky
for the fetching.
About ref=producthunt, it does not seem that product hunt uses it anymore
They do. Try clicking the "Website" button here: https://www.producthunt.com/posts/makerlog-2-0
:heavy_check_mark: No more shorten links Note: the shorten link is only displayed on hover
:warning: The full URL is displayed, and it can be long. We can trim the URL, to respect Twitter's policy on links (a maximum of 46 chars displayed) After Before
It does not affect twitter card link like this one as there is no data-expanded-url
and we need to have our own link unshorten API
Since the last time this PR had activity, Twitter launched their redesign to everyone, so I don't think this PR is functioning anymore... Are you still interested in finishing this and retargeting the new Twitter design or should I close?
Fixes #21
Features
When
data-expanded-url
attribute is available 2 features are activated :Expand URLs
Replace t.co URLS with
data-expanded-url
data Tweet with a data-expanded-urlRemove UTMs
Remove UTMs from replaced URLs, leave the UTMs inside
data-expanded-url
though: Tweet with UTMs to test this featureLimit
It does not remove
ref=producthunt
from linksIt does not affect twitter card link like this one as there is no
data-expanded-url
and we need to have our own link unshorten API