sindresorhus / screenfull

Simple wrapper for cross-browser usage of the JavaScript Fullscreen API
https://sindresorhus.com/screenfull
MIT License
7.08k stars 698 forks source link

Allow `screenfull.request` to timeout #224

Open mxdvl opened 10 months ago

mxdvl commented 10 months ago

When running Playwright tests, screenfull.request hangs indefinitely. I believe this may be because the iframe does not have allowfullscreen, but I believe that there should be a configurable timeout if the fullscreen request does not succeed after a while.

If someone else reacts with a 🚀 I’ll have a go at implementing this myself 😁

ukupat commented 5 months ago

I think we have the same issue 🤔