sindresorhus / screenfull

Simple wrapper for cross-browser usage of the JavaScript Fullscreen API
https://sindresorhus.com/screenfull
MIT License
7.08k stars 698 forks source link

screenfull.enabled = true in Android 4.3, but not supported #56

Closed chaenu closed 10 years ago

chaenu commented 10 years ago

First of all, thank you for your work!

I've noticed that screenfull.enabled returns true on the Samsung Galaxy S4 / Android 4.3 Stock Browser, where the fullscreenAPI isn't supported. But this is not a bug in screenfull, as document.webkitFullscreenEnabled returns true and the stock browser is pretending to support the fullscreenAPI (see https://code.google.com/p/chromium/issues/detail?id=180734). The HTC One / Android 4.4.2 Stock Browser returns undefined as expected and therefore screenfull.enabled is false.

Do you see any possibility to deal with this false behaviour?

sindresorhus commented 10 years ago

Not really. Only way I can think of is browser-sniffing and not super interested in adding that.

chaenu commented 10 years ago

Yes, I fully understand this. Thanks for your fast response.