search

sindresorhus / screenfull

Simple wrapper for cross-browser usage of the JavaScript Fullscreen API
https://sindresorhus.com/screenfull
MIT License
7.06k stars 698 forks source link

Include minified version on bower #75

Closed samypr100 closed 9 years ago

samypr100 commented 9 years ago

Currently being ignored on your bower.json.

Thanks!

sindresorhus commented 9 years ago

Duplicate of #67

samypr100 commented 9 years ago

Read your issue #66: https://github.com/sindresorhus/screenfull.js/issues/66

Found this stack overflow: http://stackoverflow.com/questions/16761272/how-to-configure-grunt-to-replace-bower-dependencies-by-its-minified-versions

Pretty good arguments against you (lol) as to why include minified version:

Claiming that minifying 3rd party artifacts is user's responsibility is not only odd, but would collide with so many corporate practices it's scares me to even write about. You are not supposed to do that. The sheer blame-war if something goes south... – ZenMaster Oct 10 '13 at 16:16

@SindreSorhus From the Angular Team, Best Practices. They specifically recommend using their minified file because they tweaked the settings just right. – Jacob Eggers Jan 28 '14 at 1:59

My only request is to not ignore your minified version on your bower.json. Not everyone is familiar with JS, gulp, grunt, uglify, yeoman, etc. Especially if the people come from a Java background and the only build tool for the project is Maven. If we want to setup a simple web project, adding build annotations and whatnot will confuse non familiarized developers of the steps they need to take to run the project locally on their computer. I would say that if three issues have been raised trying to achieve the same thing, it's a clear indicative of the need and usefulness of a minified version of your awesome library.