search

sindresorhus / slugify

Slugify a string
MIT License
2.56k stars 81 forks source link

Error: "Expected identifier, string or number" on Edge-18 #47

Closed vbartusevicius closed 4 years ago

vbartusevicius commented 4 years ago

On latest Edge-18 I'm getting this error: "Expected identifier, string or number". To see it, please go to https://x5e7o.csb.app/ with Edge-18 - this is the output from https://codesandbox.io/s/distracted-elgamal-x5e7o.

Basically it complains about the spread operators in slugify/index.js. I don't see any supported platforms by this package, but could it be possible to support latest Edge-18 ?

eseQ commented 4 years ago

@vbartusevicius wait for merge PR =)

sindresorhus commented 4 years ago

Sorry, I'm not interested in supporting Edge 18.

vbartusevicius commented 4 years ago

@sindresorhus could you tell why? It's just a matter of spread vs Object.assign. Even when somebody already submitter PR

eseQ commented 4 years ago

@vbartusevicius hmmm this is strange but ok

vbartusevicius commented 4 years ago

I think @sindresorhus is a bit too arrogant. @eseQ - thanks for PR, but will have to look for more open-minded library.

eseQ commented 4 years ago

@vbartusevicius we can just be thankful for @sindresorhus open-source work. Really. For IE support you can use my fork