sindresorhus / slugify

Slugify a string
MIT License
2.56k stars 81 forks source link

Add support for empty `separator` #53

Closed Arnovsky closed 4 years ago

Arnovsky commented 4 years ago

Fixes #52

sindresorhus commented 4 years ago

I think it should be explicitly documented as it's not immediately obvious that it's supported. Could add another example (in readme and index.d.ts).

Arnovsky commented 4 years ago

CI seems to failing due to an unrelated issue, something with transliterate breaking with version 0.1.1 in this commit, I have change the tests accordingly.

Arnovsky commented 4 years ago

@sindresorhus Is the documentation added OK?

sindresorhus commented 4 years ago

👍🏻