Closed SrinivasanTarget closed 8 years ago
I think it could be done a bit simpler and more DRY.
@sindresorhus Thank for your comments. Learning a lot :) Will try my best to make it as simple as possible.
@sindresorhus @SamVerschueren Hope this is fine. Please review.
Thanks, srini
You can use a multiplier that could be used everywhere instead of checking every time
var multiplier = cli.flags.bytes ? 1/8 : 1;
Thanks.Updated the PR now @SamVerschueren
Much better :)
You missed https://github.com/sindresorhus/speed-test/pull/31#discussion_r48693104
Updated the PR now @sindresorhus
Hope this is fine @sindresorhus @SamVerschueren
@sindresorhus
I guess only the last 2 comments I provided and then it's good to go! Thanks for implementing this.
@SamVerschueren Not sure about the reason for failure. Can you help me to resolve this?
It took to long (more then 17 minutes) to determine the speed of the connection between travis and the test server. Nothing we can do about it. I restarted the test, might be resolved now.
Tests are fixed now.
Yup its passed now
I guess this is good to merge. Good job :+1:
Landed. Thank you @SrinivasanTarget :)
@sindresorhus Please look into this. Also tested from my side.It works as expected but not sure how to test through test.js.
Fixes #28.