search

sindresorhus / strip-debug

Strip console, alert, and debugger statements from JavaScript code
MIT License
84 stars 15 forks source link

Upgrade to rocambole 0.3.6 #6

Closed kevinrenskers closed 10 years ago

kevinrenskers commented 10 years ago

I'm trying to use strip-debug (via gulp-strip-debug) and am getting this error:

events.js:72
        throw er; // Unhandled 'error' event
              ^
TypeError: Cannot set property 'parent' of null
    at instrumentNodes (/Users/kevin/Workspace/sling-web/node_modules/gulp-strip-debug/node_modules/strip-debug/node_modules/rocambole/rocambole.js:69:21)
    at recursiveWalk (/Users/kevin/Workspace/sling-web/node_modules/gulp-strip-debug/node_modules/strip-debug/node_modules/rocambole/rocambole.js:339:10)
    at recursiveWalk (/Users/kevin/Workspace/sling-web/node_modules/gulp-strip-debug/node_modules/strip-debug/node_modules/rocambole/rocambole.js:364:17)
    at recursiveWalk (/Users/kevin/Workspace/sling-web/node_modules/gulp-strip-debug/node_modules/strip-debug/node_modules/rocambole/rocambole.js:360:13)
    at recursiveWalk (/Users/kevin/Workspace/sling-web/node_modules/gulp-strip-debug/node_modules/strip-debug/node_modules/rocambole/rocambole.js:360:13)
    at recursiveWalk (/Users/kevin/Workspace/sling-web/node_modules/gulp-strip-debug/node_modules/strip-debug/node_modules/rocambole/rocambole.js:360:13)
    at recursiveWalk (/Users/kevin/Workspace/sling-web/node_modules/gulp-strip-debug/node_modules/strip-debug/node_modules/rocambole/rocambole.js:364:17)
    at recursiveWalk (/Users/kevin/Workspace/sling-web/node_modules/gulp-strip-debug/node_modules/strip-debug/node_modules/rocambole/rocambole.js:364:17)
    at recursiveWalk (/Users/kevin/Workspace/sling-web/node_modules/gulp-strip-debug/node_modules/strip-debug/node_modules/rocambole/rocambole.js:360:13)
    at recursiveWalk (/Users/kevin/Workspace/sling-web/node_modules/gulp-strip-debug/node_modules/strip-debug/node_modules/rocambole/rocambole.js:364:17)

When I downgrade to gulp-strip-debug 0.1.1 (which uses strip-debug 0.1.0 and rocambole 0.3.6) the error is gone and everything works. As soon as I upgrade to gulp-strip-debug 0.2.0 (which uses strip-debug 0.2.0 and rocambole 0.3.1) I get this error.

The latest gulp-strip-debug, 1.0.1, uses strip-debug 1.0.0 and rocambole 0.3.1, which results in the same error. So, it seems that rocambole 0.3.6 is the correct version to use.

Looking at package.json it used to depend on ~0.3.1 but that's now changed to ^0.3.1. Please see https://www.npmjs.org/doc/misc/semver.html: "0.x.x versions are special: since the semver spec specifies that 0.x.x versions make no stability guarantees, only the version specified is considered valid."

So either change this to ~0.3.6 or 0.3.x or 0.3.