search

sindresorhus / transliterate

Convert Unicode characters to Latin characters using transliteration
MIT License
286 stars 20 forks source link

Add Danish replacements #6

Closed rhnorskov closed 4 years ago

rhnorskov commented 4 years ago

I've added replacements for the six Danish letters Æ, æ, Ø, ø, Å, and å.

Looking at each letter's usage, it doesn't appear to be in conflict with any other uses.

sindresorhus commented 4 years ago

Tests are failing.

sindresorhus commented 4 years ago

You also need to add a test for this.

sindresorhus commented 4 years ago

Looking at each letter's usage, it doesn't appear to be in conflict with any other uses.

Seems it does: https://github.com/sindresorhus/transliterate/pull/6/files#diff-1dd241c4cd3fd1dd89c570cee98b79ddR66

So Danish needs to be disabled until #2 is done.

rhnorskov commented 4 years ago

I've disabled the replacements. But what is your source of the latin replacements? My research showed no use of the character not being transliterated to 'oe'.

sindresorhus commented 4 years ago

But what is your source of the latin replacements?

I don't remember exactly, but I just tried using a latinize method I have in Swift that uses the system APIs (which are based on ICU) and it also converted ø to o.