search

sindresorhus / trash-cli

Move files and folders to the trash
MIT License
1.33k stars 35 forks source link

verbose mode added #17

Closed pmpontes closed 5 years ago

pmpontes commented 6 years ago

Support for verbose mode included in response to issue #14

sindresorhus commented 6 years ago

This doesn't correctly handle input when it's a glob as it should then show the resolved files from the glob, not the actual glob pattern. It also does not handle the case where the supplied path doesn't exist as it will still log it as removed.

pmpontes commented 6 years ago

I see, @sindresorhus . The proper way to handle input when it's a glob and also handle the case where the supplied path doesn't exist, would be to make the promise trash returns include an argument specifying a list of the files deleted, otherwise I can't think of another workaround.

sindresorhus commented 6 years ago

would be to make the promise trash returns include an argument specifying a list of the files deleted, otherwise I can't think of another workaround.

Correct, but even that is not that easy as trash uses native binaries, so they would have to be modified to return the paths of trashed files too. I'm starting to wonder if it's really worth the effort.

sindresorhus commented 5 years ago

Closing for lack of activity.