search

sindresorhus / trash-cli

Move files and folders to the trash
MIT License
1.32k stars 35 forks source link

To alias or not to alias #8

Closed gblazex closed 8 years ago

gblazex commented 8 years ago

Inside the README it says:

Add alias rm=trash to your .zshrc/.bashrc to reduce typing & safely trash files

But the in your rm is dangerous guide you wrote:

You should no alias rm to trash as it will break external scripts relying on the behavior of rm. Instead use it directly

https://github.com/sindresorhus/guides/blob/master/how-not-to-rm-yourself.md#safeguard-rm

One of them needs updating? :)

sindresorhus commented 8 years ago

Duplicate of https://github.com/sindresorhus/trash-cli/issues/7.

gblazex commented 8 years ago

Haha wow, even the same title.

Soooory :)

gblazex commented 8 years ago

Will you also update the guide? https://github.com/sindresorhus/guides/blob/master/how-not-to-rm-yourself.md#safeguard-rm

sindresorhus commented 8 years ago

Update it how?

gblazex commented 8 years ago

You should not alias rm to trash as it will break external scripts relying on the behavior of rm.

You said alias doesn't apply in scripts, so in the guide that sentence is not needed right?

sindresorhus commented 8 years ago

Right. https://github.com/sindresorhus/guides/commit/f81249c0d5ced5dd4b0fca972aa1c300fe7044e3

gblazex commented 8 years ago

:+1: