search

sindresorhus / trash

Move files and directories to the trash
MIT License
2.58k stars 79 forks source link

Require Node.js 12.20 and move to ESM #118

Closed LinusU closed 3 years ago

sindresorhus commented 3 years ago

Tests are failing

LinusU commented 3 years ago

Should be green now ✅

As far as I can tell the previously used version of Ava didn't have a test timeout before, because the tests locally for me takes the same time now and before. Adding a timeout specifically the "tons of files" test didn't help, since that tests saturates the global event loop which makes all the tests take long time (I think). I added a --timeout=10m to work around it.

Do you want me to squash everything together? Do you want me to solve the tests timeout in another way?