sindrets / diffview.nvim

Single tabpage interface for easily cycling through diffs for all modified files for any git rev.
Other
4k stars 109 forks source link

feat: rocks.nvim/luarocks support #320

Closed mrcjkb closed 3 months ago

mrcjkb commented 1 year ago

Summary

This PR is part of a push to get neovim plugins on LuaRocks.

Things done:

The workflows are based on this guide by @vhyrro.

Notes:

[!IMPORTANT]

Adding the API key (screen shot) github-add-luarocks-api-key

harrisoncramer commented 11 months ago

Are there any plans to add this, aka Luarocks support?

We have an upstream plugin that uses diffview.nvim (it's fantastic by the way) and we'd like to be able to install it via LuaRocks to run tests in our CI/CD pipeline, if possible!

mrcjkb commented 6 months ago

As there has been no response, I will add this plugin to the NURR, which means diffview.nvim will be published to luarocks.org under the neorocks organisation account.

@sindrets if you would like to merge this one day, please ping me, and I will remove the package from the luarocks root manifest.

@harrisoncramer because diffview.nvim doesn't have tagged releases, the NURR workflow will only publish an scm rockspec. You could add it as a dependency to gitlab.nvim, but luarocks won't be able to resolve the dependency unless installing gitlab.nvim with a dev version (or using the --dev flag). For this reason, I would suggest not publishing a non-scm rockspec to luarocks until all of gitlab.nvim's dependencies have semver releases on luarocks.org.