search

sindrets / diffview.nvim

Single tabpage interface for easily cycling through diffs for all modified files for any git rev.
Other
3.74k stars 105 forks source link

bug(nightly): nvim__get_hl_defs removed causing failures in diffview.nvim #327

Closed mikesmithgh closed 1 year ago

mikesmithgh commented 1 year ago

Hey, I am on the neovim nightly build. It looks like https://github.com/neovim/neovim/pull/22693 removed nvim__get_hl_defs and DiffViewOpen is failing with the following error.

Error detected while processing command line:
Error executing Lua callback: ....local/share/nvim/lazy/diffview.nvim/lua/diffview/hl.lua:124: attempt to call field 'nvim__get_hl_defs' (a nil value)
stack traceback:
    ....local/share/nvim/lazy/diffview.nvim/lua/diffview/hl.lua:124: in function 'get_hl'
    ....local/share/nvim/lazy/diffview.nvim/lua/diffview/hl.lua:147: in function 'get_hl_attr'
    ....local/share/nvim/lazy/diffview.nvim/lua/diffview/hl.lua:166: in function 'get_fg'
    ....local/share/nvim/lazy/diffview.nvim/lua/diffview/hl.lua:430: in function 'update_diff_hl'
    ....local/share/nvim/lazy/diffview.nvim/lua/diffview/hl.lua:439: in function 'setup'
    ...ocal/share/nvim/lazy/diffview.nvim/lua/diffview/init.lua:25: in function 'init'
    ...ocal/share/nvim/lazy/diffview.nvim/lua/diffview/init.lua:260: in main chunk
    [C]: in function 'handler'
    ...ocal/share/nvim/lazy/diffview.nvim/lua/diffview/lazy.lua:21: in function '__get'
    ...ocal/share/nvim/lazy/diffview.nvim/lua/diffview/lazy.lua:36: in function '__index'
    ....local/share/nvim/lazy/diffview.nvim/plugin/diffview.lua:24: in function <....local/share/nvim/lazy/diffview.nvim/plugin/diffview.lua:23>
cleong14 commented 1 year ago

Tested the changes locally and it appears #326 should fix this issue.