search

sindrets / diffview.nvim

Single tabpage interface for easily cycling through diffs for all modified files for any git rev.
Other
3.6k stars 101 forks source link

fix(job): Line buffer needs same life cycle as the pipe reader #387

Closed NGPONG closed 1 year ago

NGPONG commented 1 year ago

Fixes #385 Fixes #371

Hi @sindrets , I have fixed the code as per the hint in your comment. Sorry for the late submit due to work-related reasons.

Since I'm a bit OCD, I wanted to keep the cool code style in Job:handle_reader intact (double utils.bind() calls). Unfortunately, many attempts failed, and I'm sorry to say that I'm still very new to lua. If you are interested in this, could you please give me some more tips?

Anyway, thank you and it's an honor to have the opportunity to work with you again!