sindrets / diffview.nvim

Single tabpage interface for easily cycling through diffs for all modified files for any git rev.
Other
3.57k stars 101 forks source link

[Bug] nvim night build warning/error when starting #493

Closed samarulmeu closed 1 month ago

samarulmeu commented 1 month ago

Description

After upgrading to nvim v0.11.0-dev-6+g06135cc21 I get this warning/error

vim.tbl_add_reverse_lookup is deprecated. :help deprecated
Feature will be removed in Nvim 0.12
stack traceback:
        vim/shared.lua: in function 'tbl_add_reverse_lookup'                                                                                                                                                              ...e/username/.vim/plugged/diffview.nvim/lua/diffview/oop.lua:13: in function 'enum'
        ...name/.vim/plugged/diffview.nvim/lua/diffview/logger.lua:101: in main chunk                                                                                                                                    [C]: in function 'require'
        .../username/.vim/plugged/diffview.nvim/lua/diffview/lazy.lua:77: in function 'handler'
        .../username/.vim/plugged/diffview.nvim/lua/diffview/lazy.lua:23: in function ' get'                                                                                                                              .../username/.vim/plugged/diffview.nvim/lua/diffview/lazy.lua:44: in function 'Logger'
        ...ame/.vim/plugged/diffview.nvim/lua/diffview/bootstrap.lua:48: in main chunk                                                                                                                                     [C]: in function 'require'
        /home/username/.vim/plugged/diffview.nvim/plugin/diffview.lua:1: in main chunk                                                                                                                            stack traceback:
        ...ount_nvim.aOKQLza/usr/share/nvim/runtime/lua/vim/lsp.lua:1092: in function 'buf_get_clients'                                                                                                                   [string "luaeval()"]:1: in main chunk

Hope that helps, thank you.

Expected behavior

No error

Actual behavior

No error on nvim start

Steps to reproduce

Just start nvim

Health check

Output of :checkhealth diffview ``` diffview: require("diffview.health").check() Checking plugin dependencies - OK nvim-web-devicons installed. Checking VCS tools - The plugin requires at least one of the supported VCS tools to be valid. - OK Git found. - OK Git is up-to-date. (2.39.2) - WARNING Configured hg_cmd is not executable: 'hg' ```

Log info

No response

Neovim version

NVIM v0.11.0-dev-6+g06135cc21
Build type: RelWithDebInfo
LuaJIT 2.1.1713484068

Operating system and version

Linux 6.1.0-21-amd64 x86_64 GNU/Linux

Minimal config

No response

sunzoje commented 1 month ago

Fix PR #492

fredrikaverpil commented 1 month ago

@sindrets Neovim 0.10.0 was released. Would be awesome to get this fixed, as 0.10.0 now crashes with this error 😄

stack traceback:
    vim/shared.lua: in function 'tbl_add_reverse_lookup'
    ...al/share/fredrik/lazy/diffview.nvim/lua/diffview/oop.lua:13: in function 'enum'
    ...share/fredrik/lazy/diffview.nvim/lua/diffview/logger.lua:101: in main chunk
    [C]: in function 'require'
    ...l/share/fredrik/lazy/diffview.nvim/lua/diffview/lazy.lua:77: in function 'handler'
    ...l/share/fredrik/lazy/diffview.nvim/lua/diffview/lazy.lua:23: in function '__get'
    ...l/share/fredrik/lazy/diffview.nvim/lua/diffview/lazy.lua:44: in function 'Logger'
    ...re/fredrik/lazy/diffview.nvim/lua/diffview/bootstrap.lua:48: in main chunk
    [C]: in function 'require'
    ...cal/share/fredrik/lazy/diffview.nvim/plugin/diffview.lua:1: in main chunk
    ...
    [C]: in function 'xpcall'
    ...ocal/share/fredrik/lazy/lazy.nvim/lua/lazy/core/util.lua:113: in function 'try'
    ...al/share/fredrik/lazy/lazy.nvim/lua/lazy/core/loader.lua:484: in function 'source'
    ...al/share/fredrik/lazy/lazy.nvim/lua/lazy/core/loader.lua:443: in function 'source_runtime'
    ...al/share/fredrik/lazy/lazy.nvim/lua/lazy/core/loader.lua:411: in function 'packadd'
    ...al/share/fredrik/lazy/lazy.nvim/lua/lazy/core/loader.lua:346: in function '_load'
    ...al/share/fredrik/lazy/lazy.nvim/lua/lazy/core/loader.lua:191: in function 'load'
    ...e/fredrik/lazy/lazy.nvim/lua/lazy/core/handler/event.lua:83: in function <...e/fredrik/lazy/lazy.nvim/lua/lazy/core/handler/event.lua:72>
    [C]: in function 'nvim_exec_autocmds'
    ...ocal/share/fredrik/lazy/lazy.nvim/lua/lazy/core/util.lua:152: in function <...ocal/share/fredrik/lazy/lazy.nvim/lua/lazy/core/util.lua:147>
sindrets commented 1 month ago

Fixed by #492.