sindrets / diffview.nvim

Single tabpage interface for easily cycling through diffs for all modified files for any git rev.
Other
4.09k stars 113 forks source link

DiffViewOpen open current index on the right side #524

Open juridiener opened 4 months ago

juridiener commented 4 months ago

Description

Hello, if I open the DiffView it opens the current index on the right side of the 2-column-layout. this is not really intuitive. Is this a cofiguration option so i can change that, or is it a real bug? Because as well in all videos of DiffView it shows that the current index is on the left side.

Expected behavior

Open the current index in the left panel.

Actual behavior

Opens the current index in the right panel even with the mini.lua file

Steps to reproduce

:DiffViewOpen

Health check

Output of :checkhealth diffview ``` - ERROR No healthcheck found for "diffview" plugin. ```

Log info

Relevant info from :DiffviewLog ``` E492: Not an editor command: DiffviewLog ```

Neovim version

NVIM v0.10.0
Build type: Release
LuaJIT 2.1.1716656478

Operating system and version

Darwin 23.5.0 x86_64

Minimal config

-- #######################################
-- ### USAGE: nvim --clean -u mini.lua ###
-- #######################################

local root = vim.fn.stdpath("run") .. "/nvim/diffview.nvim"
local plugin_dir = root .. "/plugins"
vim.fn.mkdir(plugin_dir, "p")

for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

local plugins = {
  { "nvim-web-devicons", url = "https://github.com/nvim-tree/nvim-web-devicons.git" },
  { "diffview.nvim", url = "https://github.com/sindrets/diffview.nvim.git" },
  -- ##################################################################
  -- ### ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE ###
  -- ##################################################################
}

for _, spec in ipairs(plugins) do
  local install_path = plugin_dir .. "/" .. spec[1]
  if vim.fn.isdirectory(install_path) ~= 1 then
    if spec.url then
      print(string.format("Installing '%s'...", spec[1]))
      vim.fn.system({ "git", "clone", "--depth=1", spec.url, install_path })
    end
  end
  vim.opt.runtimepath:append(spec.path or install_path)
end

require("diffview").setup({
  -- ##############################################################################
  -- ### ADD DIFFVIEW.NVIM CONFIG THAT IS _NECESSARY_ FOR REPRODUCING THE ISSUE ###
  -- ##############################################################################
})

vim.opt.termguicolors = true
vim.cmd("colorscheme " .. (vim.fn.has("nvim-0.8") == 1 and "habamax" or "slate"))

-- ############################################################################
-- ### ADD INIT.LUA SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE ###
-- ############################################################################

print("Ready!")
j-krl commented 3 months ago

I don't think you're correct. The index is on the left side, and the working tree is on the right side if you run DiffviewOpen with no arguments.