search

sine-io / cosbench-sineio

A benchmarking tool to measure the performance of Cloud Object Storage services.
MIT License
21 stars 6 forks source link

s3 range & prefetch requests #5

Closed bissenbay closed 2 years ago

bissenbay commented 2 years ago

Closes: https://github.com/kisscelia/cosbench-ehualu/issues/2

kisscelia commented 2 years ago

Hi, @bissenbay Thanks for your pull request.

I have some questions. 1st, which aws-sdk-java version do you use? As i know, disableGetObjectMD5Validation is not useful in newer sdk version(e.g. 1.12.x which i used.). and OmitStackTraceInFastThrow is to reslove issue: https://github.com/open-io/cosbench/commit/e212bd789139813fdf88dcaff9cfcdba1772ae77

2nd, SDKGlobalConfiguration.ENABLE_S3_SIGV4_SYSTEM_PROPERTY means default sign is v4, not v2, right? why use it, It's needed or not?

Thank you. ^ _ ^

bissenbay commented 2 years ago

Thanks for your questions and feedback, I've done some changes, PTAL @kisscelia .