search

sinedied / backslide

:sweat_drops: CLI tool for making HTML presentations with Remark.js using Markdown
https://sinedied.github.io/backslide
MIT License
764 stars 50 forks source link

Images not inserted in PDF? #64

Closed vincent-ferotin closed 4 years ago

vincent-ferotin commented 5 years ago

Hi @sinedied,

Sorry to bother you, as I'm not sure this issue is related to backslide, remark or decktape...

I failed to properly insert an image when slideshow is rendered as a PDF document, whereas in the browser image is well displayed. I build a minimal example in https://github.com/vincent-ferotin/backslide-imageinpdf repository, demonstrating the issue.

Material of this repository was built on a Ubuntu 19.04, with yarn as package manager, backslide@2.3.7, decktape@2.10.0 and puppeteer@1.13.0.

I found no relevant material related to broken images with decktape on remark slideshows, but the few slideshows examples I found did not contain images.

My first and naïve intuition would be that at https://github.com/sinedied/backslide/blob/master/backslide.js#L113 no other additional content but the Markdown presentation file, such as images on filesystem, is also passed to Node to be resolved -- but I'm not enough comfortable in JS to assert that.

vincent-ferotin commented 4 years ago

Please wait some hours before quicly investigating or closing this issue: I'm currently doing some additional tests, found a first workaround for my issue, then found the probably correct way to reference local images, and probably found some unexpected bugs... ^_^;