search

sinedied / backslide

:sweat_drops: CLI tool for making HTML presentations with Remark.js using Markdown
https://sinedied.github.io/backslide
MIT License
764 stars 50 forks source link

Use web-resource-inliner instead of inliner. #71

Closed cogumbreiro closed 4 years ago

cogumbreiro commented 4 years ago

web-resource-inliner has fine-grained control for ignoring certain resources, which inliner does not provide.

It would be really nice to have this level of control in backslide so that users can easily control what to inline and what not to when exporting slides. In my use case, I want to ensure webfonts are not inline, but everything else should be inlined.

cogumbreiro commented 4 years ago

The error given by the CI system is unrelated to this change: the builder is having trouble compiling hummus-gyp on newer nodejs, see issue #70. Regretably, hummus does not have a maintainer as of now.

sinedied commented 4 years ago

Good catch finding a better alternative than inliner, this one has been bothering me for a a while :) Thanks for your PR, I will try to find time to review it asap, but except some delays as I have a busy week!

I will also try to get rid of this the hummus dependency, making the decktape dependency optional like it was in v1.

cogumbreiro commented 4 years ago

@sinedied many thanks for this great project. I've been using backslide in my courses (example here) and it has been an invaluable tool. In my use case I resort to KaTeX to produce slides with code and math. Generally I share my slides with Chrome+Print with PDF, as decktape always struggles with my choice of fonts --- HTML exporting seems to be working now with this change.

sinedied commented 4 years ago

Sorry it took some time to review it, but it looks good! A release will follow soon, thanks for contributing 👍

cogumbreiro commented 4 years ago

Awesome! Thank you for accepting the merge and again for contributing a great piece of software. I really enjoyed navigating through the source code.