|| does not work if first value is 0 and second is 1.

sinedied / dmx-hue

:traffic_light: Art-Net node to control Philips Hue lights with DMX

MIT License

185 stars 22 forks source link

|| does not work if first value is 0 and second is 1. #26

Closed RobertjanTuit closed 1 year ago

RobertjanTuit commented 2 years ago

https://github.com/sinedied/dmx-hue/blob/6aa6a574f4d77dcf89ede24d7f4c008d8561f8b6/index.js#L273

Need something like to have it not always fall to second value: universe: this._args.universe === 0 ? 0 : (this._args.universe || Util.config.get('universe') || 0),

(I had config universe to 1 and was unable to argh override it to 0)

sinedied commented 2 years ago

Yes, that's an issue. Can you open a PR for this?

sinedied commented 1 year ago

Fixed in 2.0