search

sinedied / hads

:books: Markdown superpowered documentation for Node.js
MIT License
167 stars 28 forks source link

Added image with link opening in a new tab #19

Closed fabala closed 6 years ago

fabala commented 6 years ago

This patch adds an html anchor around image tags in order to open them in a new tab when clicking on them.

sinedied commented 6 years ago

Thanks! Can you just replace the var with a let to fix the CI?

fabala commented 6 years ago

Done! Sorry for the inconvenience, this is my first pull request, so I am on the learning phase!

fabala commented 6 years ago

Yohan, just one question: when this will be available thru npm?

sinedied commented 6 years ago

It's now available in 1.4.1: I just had to add a small fix for the case where an image already had a link on it. 😉