search

sineed / neo4j-rspec

MIT License
10 stars 13 forks source link

Use RSpec DSL in HasN matchers #3

Closed sineed closed 8 years ago

sineed commented 8 years ago

related to #2

sineed commented 8 years ago

@cheerfulstoic I think it became more clear, what do you think?

cheerfulstoic commented 8 years ago

Yeah, I think it's improved, for sure. It still feels a bit class-heavy. In the examples they show basically using the chains to set variable state and then evaluate it later, which is kind of what you're doing. But obviously this is more complex and I don't know if putting all of the logic into the matcher would make sense or not.

As far as I'm concerned, though, I'm just happy that it works ;)

sineed commented 8 years ago

yes, but some variables need their own descriptions and matching logic so I decided to extract them into classes again =)

cheerfulstoic commented 8 years ago

Fair enough! ;)