Fix issue with SSID containing space

sineto / nmcli-rofi

A simple manager for network connections using rofi and nmcli

MIT License

62 stars 16 forks source link

Fix issue with SSID containing space #8

Closed sheoak closed 4 years ago

sheoak commented 5 years ago

When an SSID was containing a space, the script was using only the first word.

The modified code is from the rofi-wifi-menu repository.

Fixes #5

sinetoami commented 5 years ago

hi @sheoak Sorry for the delay. I'll review your PR soon as possible. Thank you so much to fix this issue!

sheoak commented 5 years ago

Hey! It doesn't work for me anymore, not sure if I have an issue with my network or not, I will try to have a look at it today!

sheoak commented 5 years ago

See my last commit, I think this solves some other cases. I'm not sure I understand why it doesn't always work but it seem to solve the issue… I'm experiencing a little bit with the script so might want to check it works for you in all cases!

https://github.com/sheoak/nmcli-rofi/commit/7dac5846b3fad190d91f49edad54fc912ffdb3dd