sinfo / eventdeck

:calendar: The awesome web app that supports awesome events
MIT License
9 stars 3 forks source link

Make distinction between public and private API fields #267

Closed JGAntunes closed 9 years ago

JGAntunes commented 9 years ago

As discussed with @palma21 confirmed speakers and closed companies should fields that clearly state that are public and are going to be accessed from the public API.

@sinfo/dev-team For the company model we already have the history field that should act as a private description for us, leaving the description field open for receiving the public content. Maybe we should only edit description field on public companies/ speakers (hide in the client side also)?

The remaining fields are going to be shared by both public/ private requests, being: title (on speakers) img (any more?)

Although we should make people know on the client side that this fields are public and they should be careful editing them.

The other fields (like talks and such) should be on the sessions.

palma21 commented 9 years ago

Agree. The image part is trickier now for there is no upload. For the time being I'll upload all pics to static and change the link on deck

-----Original Message----- From: "João Antunes" notifications@github.com Sent: ‎01/‎02/‎2015 16:49 To: "sinfo/eventdeck" eventdeck@noreply.github.com Cc: "Jorge Palma" jorge.palma@ist.utl.pt Subject: [eventdeck] Make distinction between public and private API fields(#267)

As discussed with @palma21 confirmed speakers and closed companies should fields that clearly state that are public and are going to be accessed from the public API. @sinfo/dev-team For the company model we already have the history field that should act as a private description for us, leaving the description field open for receiving the public content. Maybe we should only edit description field on public companies/ speakers (hide in the client side also)? The remaining fields are going to be shared by both public/ private requests, being: title (on speakers) img (any more?) Although we should make people know on the client side that this fields are public and they should be careful editing them. The other fields (like talks and such) should be on the sessions. — Reply to this email directly or view it on GitHub.=

JGAntunes commented 9 years ago

Yes, on the long term we would like to support img upload.

On 1 February 2015 at 17:14, Jorge Palma notifications@github.com wrote:

Agree. The image part is trickier now for there is no upload. For the time being I'll upload all pics to static and change the link on deck

-----Original Message----- From: "João Antunes" notifications@github.com Sent: ‎01/‎02/‎2015 16:49 To: "sinfo/eventdeck" eventdeck@noreply.github.com Cc: "Jorge Palma" jorge.palma@ist.utl.pt Subject: [eventdeck] Make distinction between public and private API fields(#267)

As discussed with @palma21 confirmed speakers and closed companies should fields that clearly state that are public and are going to be accessed from the public API. @sinfo/dev-team For the company model we already have the history field that should act as a private description for us, leaving the description field open for receiving the public content. Maybe we should only edit description field on public companies/ speakers (hide in the client side also)? The remaining fields are going to be shared by both public/ private requests, being: title (on speakers) img (any more?) Although we should make people know on the client side that this fields are public and they should be careful editing them. The other fields (like talks and such) should be on the sessions. — Reply to this email directly or view it on GitHub.=

— Reply to this email directly or view it on GitHub https://github.com/sinfo/eventdeck/issues/267#issuecomment-72373411.

JGAntunes commented 9 years ago

Summing it up:

JGAntunes commented 9 years ago

@Makay11 the history field is still missing on the speakers form