singanamala / google-blog-converters-appengine

Automatically exported from code.google.com/p/google-blog-converters-appengine
Apache License 2.0
0 stars 0 forks source link

deleted comments cause exception in lj2b #13

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
lj2b crashes as soon as it finds deleted comment or comment without subject.

I tested latest trunk (r59)

Deleted comment looks like:
    <comment id="100" jitemid="41" posterid="53346" state="D"/>

Attached patch allows to export deleted comment as an empty one.

Original issue reported on code.google.com by mathemonkey on 14 Jan 2009 at 8:46

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the patch.

I see the FIXME and XXX comments.  I believe the best approach is to not include
deleted comments in the exported document.   There is no way to upload deleted
comments to Blogger.

I'll delete some comments from my livejournal blog and test it out.  I'll 
submit the
changes and you're welcome to code review it using the tools on code.google.com

Original comment by jlu...@gmail.com on 14 Jan 2009 at 8:57

GoogleCodeExporter commented 8 years ago
I've made a fix for this in r61.  Deleted comments from LiveJournal are now 
ignored

Original comment by jlu...@gmail.com on 14 Jan 2009 at 9:08

GoogleCodeExporter commented 8 years ago
Ignoring deleted comments is ok if threaded comments are not supported (issue 
#16).

Original comment by mathemonkey on 14 Jan 2009 at 9:31

GoogleCodeExporter commented 8 years ago
I'm going to close out this issue and focus efforts on support issue #16.

Original comment by jlu...@gmail.com on 15 Jan 2009 at 5:00