search

singaround / songbook

Songbook Static Site
MIT License
4 stars 7 forks source link

Search feature #18

Open singaround opened 5 years ago

singaround commented 5 years ago

We should be able to search the songs - don't want to put it in persistent menu bar as that should be straightforwardly for jumping to a song. Possibly at the top of the songs page, and top of the Index page?

It'd be fine to use Google/Bing search or similar if the results are clean. Other options are Algolia or something customs and frobtendy

RogerioY commented 5 years ago

I've been wondering if a clientside soluton is feasible. Something local to the songs by chorus/first line page that can be filled in. All we really need is the "find in page" functionality that web browsers have (is there a standard way to invoke that?).

singaround commented 5 years ago

I think the clientside solution would work okay but lacks useful things like typo correction etc.

I've also been wondering if we're good just to have a Google or DuckDuckGo site search box on the site instead - do you think anyone would care about that? DDG hasn't indexed the site yet.

J

On Sun, 31 Mar 2019, 13:44 Yasha Jannoo, notifications@github.com wrote:

I've been wondering if a clientside soluton is feasible. Something local to the songs by chorus/first line page that can be filled in. All we really need is the "find in page" functionality that web browsers have (is there a standard way to invoke that?).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/singaround/songbook/issues/18#issuecomment-478338524, or mute the thread https://github.com/notifications/unsubscribe-auth/At8ga7WAw49boCJEBKXOC7TcbR9ROoh0ks5vcK3AgaJpZM4cEaKD .

RogerioY commented 5 years ago

Most handheld devices do typo correction on input, but I imagine you're talking about similar search terms type stuff and I see why that's handy.

I don't think people will care, how backend-y will it look? I know I've seen "search provided by google" stamps on embedded search bars and that it takes you to a google results page.

DuckDuckGo seems really cool, I'd never heard of it. 🦆

singaround commented 5 years ago

For now I've made #27 which you can preview here

https://deploy-preview-27--auntieshanty.netlify.com/songs/

singaround commented 5 years ago

...it's okay, but it (a) doesn't deal well with similar words like I'd hoped (no hits for 'fire maringo' for example, despite "fire marengo" being fine. I think I might need to play a bit more with the settings for the Google Custom Search though (b) it'll turn up songs that are in the unfiltered songs list, I think, as they all live in the same namespace. If we go with this approach, I can probably fix that somehow by filtering on some page properties