search

singer-io / getting-started

This repository is a getting started guide to Singer.
https://singer.io
1.25k stars 148 forks source link

Indicate that pytz is the accepted option for tz #46

Closed zph closed 5 years ago

zph commented 5 years ago

@timvisher Here's the documentation patch for using pytz as the canonical representation of timezones in Singer taps.

timvisher commented 5 years ago

Can you resolve the conflicts with master? Afterwards, it should be as simple as wrapping at 74 characters for your paragraph, which looks awesome. :)

zph commented 5 years ago

Rebased against upstream master 👍

zph commented 5 years ago

Note circle CI is breaking because of things outside of the scope of this PR. (was failing because there were no valid checks when I forked this, now there are length limits that are matched)

timvisher commented 5 years ago

Thanks! https://github.com/singer-io/getting-started/commit/5ca8f7476795cd5a192b31b95fcd8e9ab30c769f