singer-io / getting-started

This repository is a getting started guide to Singer.
https://singer.io
1.25k stars 148 forks source link

Fixer.io endpoint used in example is deprecated #58

Open lpillmann opened 5 years ago

lpillmann commented 5 years ago

Hi there,

I was following this example that uses Fixer.io Tap and Google Sheets Target and after running the command

~/.virtualenvs/tap-fixerio/bin/tap-fixerio | ~/.virtualenvs/target-gsheet/bin/target-gsheet -c config.json

I got this error message:

ERROR Giving up request(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://api.fixer.io/2019-06-09?base=USD)
CRITICAL Error on https://api.fixer.io/2019-06-09?base=USD; received status 404: {
  "0": "#################################################################################################################################",
  "1": "#                                                                                                                               #",
  "2": "# IMPORTANT - PLEASE UPDATE YOUR API ENDPOINT                                                                                   #",
  "3": "#                                                                                                                               #",
  "4": "# This API endpoint is deprecated and has now been shut down. To keep using the Fixer API, please update your integration       #",
  "5": "# to use the new Fixer API endpoint, designed as a simple drop-in replacement.                                                  #",
  "6": "# You will be required to create an account at https://fixer.io and obtain an API access key.                                   #",
  "7": "#                                                                                                                               #",
  "8": "# For more information on how to upgrade please visit our Github Tutorial at: https://github.com/fixerAPI/fixer#readme          #",
  "9": "#                                                                                                                               #",
  "a": "#################################################################################################################################"
}

I acknowledge their API is no longer publicly available, so I suppose Fixer.io Tap has to be updated - given it does not support Fixer.io's updated terms for free subscription plans -, and we might also need to update the tutorial accordingly.

Is anyone already working on this?

luandy64 commented 5 years ago

@luipillmann I don't think anyone is actively working on this. Would you be able to submit a PR to update the tutorial?