Allow passing literal JSON strings instead of file paths

singer-io / singer-python

Writes the Singer format from Python

https://singer.io

Apache License 2.0

537 stars 129 forks source link

Allow passing literal JSON strings instead of file paths #110

Closed dcereijodo closed 3 years ago

dcereijodo commented 4 years ago

Extended load_json function in the utils to accept literal JSON strings instead of file paths. load_json will try to interpret the input string as JSON and fallback to interpret it as a file path when JSON parsing fails.

Closes #109

cmerrick commented 4 years ago

Hi @dcereijodo, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 4 years ago

You did it @dcereijodo!

Thank you for signing the Singer Contribution License Agreement.

judahrand commented 4 years ago

Looks really good! Any chance this can get merged? @cmerrick

judahrand commented 4 years ago

@cmerrick

dcereijodo commented 3 years ago

Closing this as it doesn't look like it's getting merged.